search

ulearnpro / ulearn

ULEARN - Open Source(FREE) LMS script in Laravel 5.8 and ReactJS 16.9
https://www.ulearnpro.com
MIT License
635 stars 290 forks source link

Sqlite compatibilty #7

Closed rafaelmb closed 4 years ago

rafaelmb commented 4 years ago

This PR aims to put sqlite compatibility in this project. Mysql and Sqlite differ in a few functions but I hope I've got it all.

ulearnpro commented 4 years ago

@rafaelmb will this work for all the modules? Because I couldn't see any changes in Models and DB queries...

rafaelmb commented 4 years ago

@rafaelmb will this work for all the modules? Because I couldn't see any changes in Models and DB queries...

Hi @ulearnpro I believe it solves the bugs I found running it on sqlite. The first commit changes the way we get column names to an agnostic way. The second commit add to sqlite drive only, the ability to select with regexp where, so it will not mess with mysql. This problem only affect DB::select queries and I found only four across the project.

Thanks for evaluating my Pull Request.

ulearnpro commented 4 years ago

Welcome @rafaelmb. I merged your PR.. Thanks for your PR, we are glad to receive more contributions to improve the project..