search

ulf1 / lagmat

Lagmatrix. Create array with time-lagged copies of the features
Apache License 2.0
0 stars 1 forks source link

throw exception for negative lags #1

Closed ulf1 closed 5 years ago

ulf1 commented 5 years ago

Where? https://github.com/kmedian/lagmat/blob/master/lagmat/lagmat_func.py

Why?

ulf1 commented 5 years ago

Also write an unit test for negative lags

ulf1 commented 5 years ago

done https://github.com/kmedian/lagmat/commit/1424e0b379e49a89631bd62a874f1e2f35770918

unit test - No. don't test implementation details