ulf1 / simiscore-syntax

An ML API to compute the Jaccard similarity based on shingled subtrees of the dependency grammar.
Apache License 2.0
0 stars 0 forks source link

Deprecation warning for np.float when running tests #10

Closed knit-bee closed 2 years ago

knit-bee commented 2 years ago

pytest returns a DeprecationWarning about np.float that is used in the datasketch package. Currently, the api uses version 1.5.3, the latest version on pypi. Apparently, however, this issue was already fixed in the datasketch package (at least there is a PR in the datasketch repo on github). Should we use another version/download it directly from github or ignore the warning?

ulf1 commented 2 years ago

https://github.com/ekzhu/datasketch/pull/156

ulf1 commented 2 years ago

datasketch>=1.5.4