Question: Why strict version requirement on Infomap

ulfaslak / infostop

Python package for detecting stops in trajectory data

Other

62 stars 9 forks source link

Question: Why strict version requirement on Infomap #23

Closed VRehnberg closed 1 year ago

VRehnberg commented 1 year ago

The Infomap version requirement was made strict in commit 8df4e551. What's the reason for this?

I couldn't find any braking changes mentioned in the changelog that would be problematic (the only use of infomap I found was here).

Incidentally, if I would investigate if this can be relaxed do you have an idea what is susceptible to break (so I know what tests would be sufficient to tell whether it works or not).

VRehnberg commented 1 year ago

So after some light testing I don't see any issues with 2.7.1 at least.

ulfaslak commented 1 year ago

Some braking changes to Infomap (API changes), happened after we built this, so I set the hard requirement on versioning. This should be updated though. You are welcome to raise another issue asking for an update to the requirement. And as always, since I'm too busy with life right now to actually do it, your contribution in the form of a PR is MUCH appreciated 🙏.