ulfjack / ryu

Converts floating point numbers to decimal strings
Apache License 2.0
1.2k stars 100 forks source link

[WIP] fix misbehavior with trailing decimals #182

Closed biojppm closed 3 years ago

biojppm commented 4 years ago

This PR is meant to fix #181 . Not sure on the right way to go about it, so would be glad to have some early feedback.

ulfjack commented 4 years ago

Hmm, I'm not sure about this. It's definitely a problem if the code returns SUCCESS but an incorrect result. That part must be fixed.

I was hoping to expand the code to handle arbitrary-length inputs (and that is not a small change). Handling a few additional (unnecessary) trailing zeros is nice to have, but I'm tempted to say that we should implement the arbitrary-length input case instead. Except for my lack of time.