search

uli / basicengine-firmware

BASIC Engine Firmware
78 stars 16 forks source link

Added French keymap as "CONFIG 1,3". #11

Closed a2ff closed 5 years ago

a2ff commented 5 years ago

Hello Uli, I attended your FOSDEM2019 talk and loved the idea, so I made 25 boards as a self-teaching experiment (well, 24 as one VS23010 is dead). I finally added French keyboard support. I was slightly worried by the comment in SAVE CONFIG about a possibly irrecoverable situation, so I was thinking about "press shift while booting to disable loading /flash/.config" but that would require moving PS/2 init earlier than the early init function, and I am not sure what causes the keyboard to be polled or whether it is interrupt-driven. To be continued.

uli commented 5 years ago

Merged. Thank you for your contribution!

About the config situation: I think it would be easiest to implement an override, so that a .config file on the SD card supersedes one in flash. That would only require minimally intrusive changes to basic_init_file_early() (move the loadConfig() call past the SD initialization), and to reset the config it would be sufficient to create an empty .config file on the SD card.