search

uli / basicengine-firmware

BASIC Engine Firmware
78 stars 16 forks source link

CIRCLE and RECT Command fill bug #12

Closed bitartrate closed 5 years ago

bitartrate commented 5 years ago

The CIRCLE and RECT commands now have a bug where if you use the do not fill parameter (-1) it instead fills circle in with white and rectangle in with the color parameter. It was working in nightly build version 349.

I find the commands in "basic_video.cpp" but I do not yet see how "sc0.circle" for instance interacts within the rest of the source code. Assistance would be appreciated. Thank you.

bitartrate commented 5 years ago

I have compiled and verified that this commit fixes the fill issue and also greatly speeds the CIRCLE rendering on screen.

However, I notice that the RECT command does not draw a line to the exact coordinates of the corners. I mean it looks to the eye like there are missing pixels in the corners. Should I open a different Issue for this?

bitartrate commented 5 years ago

Firmware V0.88-alpha-384 (basicengine-hosted-x86_64-v0.88-alpha-384-gd14f.tar.gz) has fixed the RECT command issue. Thank you, Uli