search

uli / basicengine-firmware

BASIC Engine Firmware
78 stars 16 forks source link

sdfiles::rmdir() doesn't work as expected #27

Closed konimaru closed 4 years ago

konimaru commented 4 years ago

mkdir "some_name" creates a directory in the CWD. Removing said directory with rmdir "some_directory" does not work (I get font corruption which is cured by calling e.g. files again).

The directory can in fact only be removed with rmdir "/sd/some_directory".

konimaru commented 4 years ago

Font corruption is most likely due erroring out after SD_BEGIN() without matching SD_END().

konimaru commented 4 years ago

Fixed locally (pending verification).

bitartrate commented 4 years ago

In the official nightly build I have verified the font corruption but rmdir "/sd/some_directory" did not remove the directory for me. I cloned your repo with git clone --branch rmdir http://github.com/konimaru/basicengine-firmware.git But I still see the font corruption with rmdir"some_directory" With this build the rmdir"/sd/some_directory" did remove the directory though.

konimaru commented 4 years ago

Well that would be because I haven't committed any changes yet :)

bitartrate commented 4 years ago

You did say 'locally', didn't you :) ::palm face::

bitartrate commented 4 years ago

I have confirmed that rmdir does work as intended by this fix.