RECT command is inconsistent

uli / basicengine-firmware

BASIC Engine Firmware

78 stars 16 forks source link

Closed konimaru closed 4 years ago

konimaru commented 4 years ago

fill colour == -1

rectangle is one pixel short in each direction, e.g.
- RECT100,100,102,102,200,-1 only gives me 2x2 pixels

fill color != -1

x dimension is now correct but height is still one short (3 by 2 with the example above)
fill colour is in fact line colour
I'd expect the border still to be drawn in line colour, this isn't the case
special cases w=0 || h=0 and w=0 && h=0 are not handled

bitartrate commented 4 years ago

I thought I was seeing this but I was always drawing big rectangles and was not sure I could trust my eyes. I have confirmed your bug.

uli commented 4 years ago

I'll assume this works now.

konimaru commented 4 years ago

Works for me. Ta