Closed konimaru closed 4 years ago
The second and third commits are effectively fixups for the first; please squash them into it.
Ah, the dreaded rebase :) Just in case you're more experienced with this., I always manage to get the squashing bit right. Then however it asks me to merge my remote branch (as they have diverged). So I effectively end up with the squashed commit and a merge commit. Is that expected behaviour?
OK, I figured it out. But it seems that my branch is now beyond help. I create a new pull request.
Fixes #42.