uli / basicengine-firmware

BASIC Engine Firmware
78 stars 16 forks source link

SDL version crashes when using SAVE CONFIG #48

Open bitartrate opened 4 years ago

bitartrate commented 4 years ago

This seems like it will end up being related to issue #40 SAVE CONFIG crashes the SDL version.

bitartrate commented 4 years ago

The native version when using CHDIR crashes/locks-up the BE making an "engine" type sound. Could be related to this issue #48

uli commented 4 years ago

No, that was related to the syntax change. Just pushed a fix.

bitartrate commented 4 years ago

As of firmware ver.548. Native version no longer crashing due to above syntax change

bitartrate commented 4 years ago

On the SDL side SAVE CONFIG now makes a .config file but does not seem to read it when restarting basic.sdl

uli commented 4 years ago

Can't reproduce that, works for me.

bitartrate commented 4 years ago

I have expanded my config settings testing and find that some config settings do get saved and work such as beeper volume and font. It is the SCREEN mode that I cannot get to come up on the next launch.

uli commented 4 years ago

That should take care of it.

Does this issue also exist on ESP8266?

bitartrate commented 4 years ago

firmware v.567 on the SDL side is now correctly saving and recalling CONFIG 4,x

however v.567 in native is not saving/recalling CONFIG 4,X. I did test it with CONFIG 7,X and that is working.

konimaru commented 4 years ago

Saving the mode is OK but after the config is initially loaded there is never a vs23.setMode() call done and vs23.begin() doesn't take a mode parameter (but calls setMode(SC_DEFAULT)).

uli commented 4 years ago

That should do. Please give me feedback on how it works, I have not actually tested these platforms yet.

konimaru commented 4 years ago

Works for hosted.

bitartrate commented 4 years ago

Works for SDL and native versions