search

uli / basicengine-firmware

BASIC Engine Firmware
78 stars 16 forks source link

min9 clip #50

Closed konimaru closed 4 years ago

konimaru commented 4 years ago

Fixes #49. Minor downside is that the minimum window with is now 9 pixels. I can get it down to 1 but this raises the question of how useful this would be.

uli commented 4 years ago

Cool! I think we can safely ignore the issue with the minimum window size.

Since this is effectively a rewrite of the entire BG drawing code and thus far from a trivial contribution, I would like to ask you to add two things to the patch, though:

  1. An overview of how it works, and
  2. Your copyright in the license header.

Thank you!

konimaru commented 4 years ago

Will do.

konimaru commented 4 years ago

Hope this is what you had in mind :) Now squashed.

uli commented 4 years ago

Excellent, thanks a lot.