search

uli / basicengine-firmware

BASIC Engine Firmware
78 stars 16 forks source link

tvutil/ntsc: removed need for empty dummy line #61

Closed konimaru closed 4 years ago

konimaru commented 4 years ago

Fixes #58. After working around another h/w bug.

konimaru commented 4 years ago

Had to add tv_clerLine to basic_video group like tv_scroll_down & Co. Now program load times are back to normal (12sec for sokoban.bas down to 2sec).

konimaru commented 4 years ago

What's blocking this from being merged?

If you don't want/like this, OK, but at least tell me!

uli commented 4 years ago

It needs to be reviewed, and I haven't found the time to do that because Life etc. That's all there is to it. I'll see that I get around to do it soon.

konimaru commented 4 years ago

Perfectly OK, no rush. Take care!

uli commented 4 years ago

Had to throw this out again; in the SDL build clearing doesn't work. Run basic.sdl, then press Ctrl-L and see.

uli commented 4 years ago

I also don't know how to set this PR to unmerged again...

konimaru commented 4 years ago

How do I get hold of <SDL/SDL_gfxPrimitives.h>? IOW, which package(s) do I need to install to have make sdl succeed?

Never mind, removing this is sufficient.

konimaru commented 4 years ago

From the looks of it, SDL's MoveBlock function doesn't work vs23s010 style. The latter honors live updates while moving stuff around. SDL simply takes a snapshot of what is there and copies it somewhere else.

I'd argue all platforms should have the same behaviour, in this case following h/w. Your call.