ulid / javascript

Universally Unique Lexicographically Sortable Identifier
MIT License
3.04k stars 107 forks source link

Fix time byte ordering in binary diagram #9

Closed tsenart closed 7 years ago

tsenart commented 7 years ago

Ref: https://github.com/RobThree/NUlid/issues/1

codecov-io commented 7 years ago

Current coverage is 82.85% (diff: 100%)

Merging #9 into master will not change coverage

@@             master         #9   diff @@
==========================================
  Files             2          2          
  Lines            70         70          
  Methods          20         20          
  Messages          0          0          
  Branches          8          8          
==========================================
  Hits             58         58          
  Misses           12         12          
  Partials          0          0          

Powered by Codecov. Last update 163da55...de4652c

tsenart commented 7 years ago

@alizain: BTW, would you please link my go-ulid implementation in the README? Have a look at it too :-)

darccio commented 7 years ago

It is a honor to have a repo forked by @tsenart :+1: If you want to create a PR for your commits, I'll be happy to merge them and give proper credit.

tsenart commented 7 years ago

@imdario: Don't make me blush :-) I'm afraid it started as a fork for some little changes, but it became a full blown re-write. There's not much left of the original code. Do you think I should re-open the repo from scratch?

darccio commented 7 years ago

If that is the case, I think you should. I'll check your implementation and decide what I'll do with mine. In any case, I'll link yours.

tsenart commented 7 years ago

@imdario: https://github.com/oklog/ulid

tsenart commented 7 years ago

@alizain: Ping

alizain commented 7 years ago

🎉 thanks @tsenart, sorry for the delay!

tsenart commented 7 years ago

@alizain: No worries. You're welcome! Also, wanna link the repo in your README?

alizain commented 7 years ago

Just did 😄