search

ulikunitz / xz

Pure golang package for reading and writing xz-compressed files
Other
485 stars 45 forks source link

Add Plan 9 support #22

Closed henesy closed 5 years ago

henesy commented 6 years ago

Proposed changes to add Plan 9 support for gxz program.

I am open to changes for fitting better with the rest of the project if formatting or other details are inconsistent with project standards.

ulikunitz commented 6 years ago

I'm happy to support Plan9. But the patches require improvement.

Here are the steps that I want you to take:

1) Remove file_plan9.go

The file is redundant and contains all the code from file.go. Any change in file.go would be required to be replicated for file_plan9.go. I suggest another approach.

2) Move the signalHandler function out of file.go to sighandler.go.

Add a build tag !plan9 in the sighandler.go file.

3) Modify sighandler_plan9.go

Remove the build tag. The suffix _plan9 is sufficient. It appears that Plan9 doesn't require signal handling. If that is the case return only the quit channel, everything else is not required. I suggest to add documentation comment stating that signal handling is not required.

4) Remove plan9 build tag from internal/term/isterminal_plan9.go

The _plan9 suffix is sufficient. There is no build tag needed. I suggest also to change the comment by stating why Plan9 is always returning false.

ulikunitz commented 5 years ago

I have not received feedback for several months. I'm closing the request without merging.