search

ulion / jsonform

Build forms from JSON Schema. Easily template-able. Compatible with Twitter Bootstrap out of the box.
http://ulion.github.io/jsonform/playground/
MIT License
49 stars 27 forks source link

V4 schema not supported by JSV #17

Closed epitomus closed 9 years ago

epitomus commented 9 years ago

Problem is (I think) that the schema is converted to V4 regardless of validator (convertSchemaV3ToV4), which in the case of creating an array of 'required' fields at the top level breaks the JSV V3 validation.

I'm using z-schema now anyway, which works fine, but as JSV is still bundled and nominally supported elsewhere, it should work everywhere.

ulion commented 9 years ago

It did, since JSV does not support V4, it looks out of maintain and no longer updated.

2015-07-24 10:15 GMT+08:00 epitomus notifications@github.com:

Problem is (I think) that the schema is converted to V4 regardless of validator (convertSchemaV3ToV4), which in the case of creating an array of 'required' fields at the top level breaks the JSV V3 validation.

I'm using z-schema now anyway, which works fine, but as JSV is still bundled and nominally supported elsewhere, it should work everywhere.

— Reply to this email directly or view it on GitHub https://github.com/ulion/jsonform/issues/17.

Ulion

epitomus commented 9 years ago

Yeah, I guess the best option would be to remove support for JSV / V3.

ulion commented 9 years ago

I just removed JSV in my fork. thx.

2015-07-24 10:35 GMT+08:00 epitomus notifications@github.com:

Yeah, I guess the best option would be to remove support for JSV / V3.

— Reply to this email directly or view it on GitHub https://github.com/ulion/jsonform/issues/17#issuecomment-124295639.

Ulion

epitomus commented 9 years ago

No probs, thanks for removing it!