search

ulion / jsonform

Build forms from JSON Schema. Easily template-able. Compatible with Twitter Bootstrap out of the box.
http://ulion.github.io/jsonform/playground/
MIT License
49 stars 27 forks source link

Collaborate on changes? #8

Open Coridyn opened 9 years ago

Coridyn commented 9 years ago

Hi ulion,

Thanks for maintaining this library, it's been a great help. I've been working with jsonform but keep running into problems with the original library.

I'd like to make some changes to add some features and fix some issues but some of them are breaking changes. Instead of creating a whole new fork to compete with yours, would you be interested in collaborating on these changes?

The main areas I want to improve are:

  1. Create standard array functions - make a set of standard functions that can be used to work with arrays
    • Remove duplicated code in 'array' and 'tabarray'
    • Make it easier for everyone else to create their own array views
  2. Add extra view callbacks (e.g. view.onAfterRender())
    • Let parent views manipulate/interact with the child template after it's been generated (no easy eay to do this at the moment).
  3. Bring tests up to date
  4. Split up source files
    • Working with a ~4500 line file gets really frustrating.

Would you be interested in discussing these items or accepting pull requests in these areas?

Thanks, -Coridyn

ulion commented 9 years ago

Hi, Coridyn, glad you can work on jsonform, I did some fix and little enhancement on the original fork, and now maintain my dev fork, add feature I will using, fix bug if I can.

so, I will help you, and as long as the code is relative stable and works, I can merge your changes.

2015-03-29 16:01 GMT+08:00 Coridyn notifications@github.com:

Hi ulion,

Thanks for maintaining this library, it's been a great help. I've been working with jsonform but keep running into problems with the original library.

I'd like to make some changes to add some features and fix some issues but some of them are breaking changes. Instead of creating a whole new fork to compete with yours, would you be interested in collaborating on these changes?

The main areas I want to improve are:

1.

Create standard array functions - make a set of standard functions that can be used to work with arrays

  • Remove duplicated code in 'array' and 'tabarray'

    • Make it easier for everyone else to create their own array views 2.

    Add extra view callbacks (e.g. view.onAfterRender())

  • Let parent views manipulate/interact with the child template after it's been generated (no easy eay to do this at the moment). 3.

    Bring tests up to date 4.

    Split up source files

  • Working with a ~4500 line file gets really frustrating.

Would you be interested in discussing these items or accepting pull requests in these areas?

Thanks, -Coridyn

— Reply to this email directly or view it on GitHub https://github.com/ulion/jsonform/issues/8.

Ulion

Coridyn commented 9 years ago

Thanks, I'll start making changes on my fork and send through pull requests as I finish things.