search

ulises-jeremias / dotfiles

HorneroConfig is a comprehensive dotfiles framework, tailored for seamless customization of diverse window management setups across various operating systems. Just like the skilled hornero bird meticulously shapes its nest, HorneroConfig empowers you to craft a digital environment that's robust, uniquely yours, and beautifully organized!
https://ulises-jeremias.github.io/dotfiles
MIT License
92 stars 1 forks source link

Install doesn't work without LastPass #36

Closed claviola closed 7 months ago

claviola commented 7 months ago

Describe the bug

Install doesn't work without LastPass

Expected Behavior

Automated deployment of the dotfiles/a mention of the dependency in the docs

Current Behavior

🔃 Running '/home/claviola/.dotfiles/install.sh'
Installing chezmoi to '/home/claviola/.local/bin/chezmoi'
info found version 2.46.0 for latest/linux/amd64
info installed /home/claviola/.local/bin/chezmoi
Running 'chezmoi init --apply --source=/home/claviola/.dotfiles'
chezmoi: template: dot_config/private_credentials/private_github_access_token_notifications.tmpl:1:11: executing "dot_config/private_credentials/private_github_access_token_notifications.tmpl" at <lastpassRaw "github_access_token_notifications">: error calling lastpassRaw: exec: "lpass": executable file not found in $PATH

If I install the lastpass-cli package so that lpass exists:

Running 'chezmoi init --apply --source=/home/claviola/.dotfiles'
Error: Could not find decryption key. Perhaps you need to login with `lpass login`.

So it seems like this is a hard dependency.

Reproduction Steps

Run the script on https://github.com/ulises-jeremias/dotfiles?tab=readme-ov-file#getting-started- on a (relatively) pristine Debian VM

Possible Solution

Make LastPass optional

Additional Information/Context

No response

Version used

8f6c5768ca20471e01e602555fc32f5b13499a0b

Environment details (OS name and version, etc.)

Debian 12.4 (bookworm)

ulises-jeremias commented 7 months ago

@claviola thanks for opening this issue! will do some changes asap to make lastpass an optional dependency

ulises-jeremias commented 7 months ago

@claviola I just fixed this issue. I made it to only use lastpass when the variable personal is set. You can check this commit for reference: https://github.com/ulises-jeremias/dotfiles/commit/8e92d18df47f430884b3017b287217772b85816e