search

uliska / collaborative-lilypond-editing

Proof-of-concept project on collaborative music editing using LilyPond
6 stars 0 forks source link

Octavation of piano left hand bars 1 to 4 #10

Closed colinghall closed 12 years ago

colinghall commented 12 years ago

Bars 1 to 4 of the piano left hand are an octave too low.

colinghall commented 12 years ago

Well, I can see what's wrong here. The file is set up to use \relative. I'm used to entering my music without relative.

Are we committed to using \relative?

I prefer to look at a piece of manuscript, figure out the octavation, and then type the music in the correct octave.

Cheers, Colin.

uliska commented 12 years ago

Corrected. Please check

BTW this is a musicalcontent issue, not engraving

uliska commented 12 years ago

P.S.: Better commit msg?

colinghall commented 12 years ago

What about the commit msg?

uliska commented 12 years ago

I assumed your earlier comment and link about commit messages referred to the messages of my earlier commits. So i tried to write a better one this time ;-)

colinghall commented 12 years ago

On Wed, Jun 06, 2012 at 05:05:26PM -0700, uliska wrote:

I assumed your earlier comment and link about commit messages referred to the messages of my earlier commits. So i tried to write a better one this time ;-)

Ah! I see.

Well, yes, it is better that it is less than 50 characters and it is very clear in the git log. Thanks for adopting this.

I just did a git pull and got your changes! This collaborative working is excellent!

I'm going to sleep now. Talk again soon.

Cheers, Colin.

Colin Hall