uliska / lilyglyphs

Make LilyPond's notational elements available in Lua- and XeLaTeX
30 stars 13 forks source link

Added support for LuaLaTeX #59

Closed davebellows closed 11 years ago

davebellows commented 11 years ago

Changed the core/generalAccess.inp file to add support for LuaLaTeX and a little code to check which engine (XeTeX or LuaTeX) is being used.

uliska commented 11 years ago

As mentioned in my email I will look into this ASAP but not earlier than end of next week. I ran a quick test against the lilyglyphs manual (admittedly a rather complex document) and was only partially successful. Of course many of the errors may have to do with other incompatibilities in the files (I don't know enough about the differences to tell off my hat). But a few errors may be relevant:

davebellows commented 11 years ago

I had noticed that the manual wouldn't compile and will look into that next. Apparently I need to fork the documentation as well (?).

Anyway, at least I now have some familiarity with Git and hopefully will remember enough to be able to contribute more stuff.

uliska commented 11 years ago

No, you don't have to fork that separately. Of course the documentation is within the repository.

I suggest we first make sure that the package works with LuaLaTeX too and then see to it that the manual can be compiled both ways. As said I don't know enough about the different systems or how to set up documents.

Basically I'd be interested in switching to LuaLaTeX completely (for my own documents that is) because XeLaTeX lacks one feature I would love to use: microtype (in particular I miss the optical alignment of text borders).

One general suggestion: Please work in newly created feature branches and submit those as pull requests. While it is generally a good idea to work in branches it particularly makes it easier to fetch and compare versions if I have them in a separate entity.

davebellows commented 11 years ago

When I tried to compile the manual I ended up having to download several more files in order for it to work. Perhaps I didn't do something correctly along the way.

And yes, the more complete support for microtype is worth changing over for. And also for a newer package called selnolig which only works with LuaTeX (it selectively disables ligatures for compound words (especially useful for German!).

I will create a feature branch and work from there once I figure out what that means and how to do it.

uliska commented 11 years ago

http://git-scm.com/book/en/Git-Branching-Basic-Branching-and-Merging

If you're on the command line you can simply enter git checkout -b featurebranch then you have a new branch that works independently (of course you should chose a more telling name than featurebranch). checkout lets you switch the context, the -b option (in this case) creates the non-existing branch for you.

When you now commit you commit to that branch while the other branches (master in particular) don't know about that.

When you want to push for the first time you have to write git push origin featurebranch:featurebranch to tell Git where to push your commits to because the remote repo doesn't know this branch.

Later you can simply git push and Git will know where to push the material of the current branch.

uliska commented 11 years ago

With your new pull request you actually have submitted an equal commit as this one (not the same but an equal one). Therefore I 'reject' this request, so it's nothing personal ;-)