ulissigroup / finetuna

Active Learning for Machine Learning Potentials
MIT License
45 stars 11 forks source link

Ensemble doesn't need to be made in OAL on instantiation #5

Closed zulissi closed 2 years ago

zulissi commented 3 years ago

We don't need to actually make an ensemble in the online active learning until we're certain we're going to need. For example, if the first point is the same as the training data, we should just use the data and make/update the ensemble as points are added.

https://github.com/ulissigroup/al_mlp/blob/buildfix/al_mlp/online_learner.py#L79

zulissi commented 3 years ago

Addressed in #9