ulissigroup / vasp-interactive

GNU Lesser General Public License v2.1
58 stars 12 forks source link

Tolerance for round-off error of lattice parameters #20

Closed alchem0x2A closed 3 years ago

alchem0x2A commented 3 years ago

Thanks @LoryWangxx proving the edge case. When the sequential atoms objects provided to VaspInteractive are read from a trajectory file, the cell parameter may suffer from round-off error. This may cause VaspInteractive to think they are having different cell parameters (due to inherited ase-calculator behavior). See atoms in moving.traj.zip

image

A resolution to this issue may be to add default round-off tolerance for cell parameter alone in VaspInteractive. User can request a slightly loose criteria for cell but position change still using default limit (1e-15)