search

ulklc / covid19-timeseries

Covid19 timeseries data store
MIT License
38 stars 9 forks source link

#Warning# "cured" will be changed with "recovered" #8

Closed pdobsan closed 4 years ago

pdobsan commented 4 years ago

Thank you for providing these data sets! In the view of JSU's dropping the recovered, yours is particularly welcome. May I ask how you collect them, is the crawling code publicly available?

Is the cured different from the JSU's former category recovered? If not, cured is a bit missleading name, recovered would be more appropriate, I believe.

ulklc commented 4 years ago

Yep, i agree. I am labelling this issue as enhancement, and it will be replaced as "recovered" next report generation.

ulklc commented 4 years ago

And currently crawling code is not opensource yet (I didnt pushed codebase to github yet :]). I have a plan to share it after the re-structure.

shubhrampandey commented 4 years ago

Thanks for sharing the data. It will be very helpful for many app developers as JHU dropped the recovered cases it is very much appreciated that you kept it as cured cases. Just want to ask one: what is the frequency of updating the data and how much it is reliable. Please don't take my questing another way. Once again thanks for this repository, I know many people who are dependent on JHU data so now the traffic on this repository going to increase.

ulklc commented 4 years ago

Actually my snapshots is not reliable much. Crawlers are taking snapshot every hours and compare with history. If snapped data is lower than history crawlers is sending notification to me. I am checking notifications and updating mongo database with other sources as manually. For community corrections, i already created issue template. With this way i hope we can increase data reliablity. Recovered values is not providing from WHO anymore. But some dashboards is still providing this data from user reports. Final snapshots is uploading every day at 00:00 GMT-0.

shubhrampandey commented 4 years ago

Actually my snapshots is not reliable much. Crawlers are taking snapshot every hours and compare with history. If snapped data is lower than history crawlers is sending notification to me. I am checking notifications and updating mongo database with other sources as manually. For community corrections, i already created issue template. With this way i hope we can increase data reliablity. Recovered values is not providing from WHO anymore. But some dashboards is still providing this data from user reports. Final snapshots is uploading every day at 00:00 GMT-0.

Ok!!!! Thanks....So will you still provide the recovered data?

ulklc commented 4 years ago

As long as any web site shares the number of recovered people, I will continue to provide

pdobsan commented 4 years ago

Yep, i agree. I am labelling this issue as enhancement, and it will be replaced as "recovered" next report generation.

Great, thank you. Just an other minor nitpick. I suggest to use exactly the same category names what JSU used, that is confirmed, recovered and deaths ; note the last. That would increase the likelihood of people transitioning to your API.

shubhrampandey commented 4 years ago

Ok...Thanks a lot....Hence I am referrening to yoru repo...

You can check the current status of the app here: https://shubhrampandey.shinyapps.io/coronaVirusViz/

shubhrampandey commented 4 years ago

Also could you please let me know the country code follow which standard naming convention like ISO2 or ISO3 as I have to use it in spatial map Thanks

ulklc commented 4 years ago

ISO 3166-1 alpha-2

ulklc commented 4 years ago

Changes deployed