ulli-kroll / rtl8188fu

rtl8188fu driver for linux / rtlwifi prepare
GNU General Public License v2.0
62 stars 296 forks source link

Make error in Ubuntu 19.04 #7

Open alac1984 opened 5 years ago

alac1984 commented 5 years ago

I'm trying to compile this driver in Ubuntu 19.04. make outputs an error:

/opt/rtl8188fu/os_dep/linux/os_intfs.c:956:22:` error: initialization of ‘u16 (*)(struct net_device *, struct sk_buff *, struct net_device *)’ {aka ‘short unsigned int (*)(struct net_device *, struct sk_buff *, struct net_device *)’} from incompatible pointer type ‘u16 (*)(struct net_device *, struct sk_buff *, struct net_device *, u16 (*)(struct net_device *, struct sk_buff *, struct net_device *))’ {aka ‘short unsigned int (*)(struct net_device *, struct sk_buff *, struct net_device *, short unsigned int (*)(struct net_device *, struct sk_buff *, struct net_device *))’} [-Werror=incompatible-pointer-types]
956 | .ndo_select_queue = rtw_select_queue,
| ^~~~~~~~~~~~~~~~
/opt/rtl8188fu/os_dep/linux/os_intfs.c:956:22: note: (near initialization for ‘rtw_netdev_ops.ndo_select_queue’)
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:290: /opt/rtl8188fu/os_dep/linux/os_intfs.o] Error 1
make[1]: *** [Makefile:1653: _module_/opt/rtl8188fu] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-5.3.0-19-generic'
make: *** [Makefile:435: modules] Error 2

rtl8188fu.ko is not compiled.

Any insights?

hkarora commented 4 years ago

same happening with me. got any solution?

lsegala commented 4 years ago

same issue for me.

Ubuntu 18.04.3 LTS

Linux version 5.3.0-26-generic (buildd@lgw01-amd64-039) (gcc version 7.4.0 (Ubuntu 7.4.0-1ubuntu1~18.04.1)) #28~18.04.1-Ubuntu SMP Wed Dec 18 16:40:14 UTC 2019

alac1984 commented 4 years ago

Solution to compile in Ubuntu 19.04: Edit the Makefile in the extracted folder (~/rtl8188fu) and insert right below the 22 line (right below the EXTRA_CFLAGS += -I$(src)/hal/phydm):

EXTRA_CFLAGS += -Wno-error=incompatible-pointer-types

Save the file and compile it again.

Explanation: Kerneis above version 4.19 were altered and do not recognize the string (.ndo_select_queue = rtw_select_queue)

As seen in: https://github.com/smlinux/rtl8723de/issues/27

ZeeMastermind commented 4 years ago

Solution to compile in Ubuntu 19.04: Edit the Makefile in the extracted folder (~/rtl8188fu) and insert right below the 22 line (right below the EXTRA_CFLAGS += -I$(src)/hal/phydm):

EXTRA_CFLAGS += -Wno-error=incompatible-pointer-types

Save the file and compile it again.

Explanation: Kerneis above version 4.19 were altered and do not recognize the string (.ndo_select_queue = rtw_select_queue)

As seen in: smlinux/rtl8723de#27

You are fantastic!