search

ulmo-dev / ulmo

clean, simple and fast access to public hydrology and climatology data.
http://ulmo.readthedocs.org
Other
169 stars 63 forks source link

NOAA GOES reader #178

Closed emiliom closed 3 years ago

emiliom commented 4 years ago

Review and merge NASA GOES reader PR from @flynnpc. This new reader replaces the USGS EDDN reader, which is no longer functional (web service is inaccessible).

emiliom commented 4 years ago

Once the issue of the failing test is addressed (see comments at #173), I'll add header RST docstrings to noaa/__init__.py, noaa/goes/__init__.py and noaa/goes/core.py; to be adapted from the EDDN docstrings. I'll assume that the new NOAA GOES reader gets at exactly the same data as the EDDN reader and the replacements for the two EDDN links are https://dcs1.noaa.gov/ and https://dcs1.noaa.gov/LRGS/DCP-Data-Service-14.pdf

Then add a corresponding entry to docs/api.rst and check that the sphinx autodoc is working as expected.

Finally, remove all EDDN code, documentation and tests.

emiliom commented 4 years ago

PR #187 was indirectly related to this, but was withdrawn.

solomon-negusse commented 4 years ago

Hey @emiliom, Just FYI - we're not ready to push the updates in the withdrawn PR but we should finish up this PR soon.

emiliom commented 3 years ago

See this new PR, #199

emiliom commented 3 years ago

Alright, the test passed using the the new way to build a dev conda environment (which I'll document). Woo-hoo! I'm closing this issue.