search

ulmo-dev / ulmo

clean, simple and fast access to public hydrology and climatology data.
http://ulmo.readthedocs.org
Other
169 stars 63 forks source link

Update twdb_fts parser #186

Closed rhroberts closed 4 years ago

rhroberts commented 4 years ago

Updated the twdb_fts parser in ulmo/usgs/eddn/parser.py to correctly handle battery voltage and water level data. Added test set to ulmo/tests/usgs_eddn_test.py.

solomon-negusse commented 4 years ago

Hi @emiliom, We are still using usgs.eddn in production until we finalize the noaa.goes module and Rusty's work here is a temporary patch that we'll later apply to noaa.goes.

emiliom commented 4 years ago

Thanks @solomon-negusse and @rhroberts. I thought USGS EDDN (the service, not the ulmo reader) was no longer available at all. So it is still usable after this PR?

I'll merge later today. Tests are passing and there are no merging issues.

emiliom commented 4 years ago

For tracking: this PR is related to #178

rhroberts commented 4 years ago

thanks, @emiliom!