Replace suds-jurko dependency with suds-community

ulmo-dev / ulmo

clean, simple and fast access to public hydrology and climatology data.

http://ulmo.readthedocs.org

Other

169 stars 63 forks source link

Replace suds-jurko dependency with suds-community #189

Open emiliom opened 4 years ago

emiliom commented 4 years ago

suds-jurko was abandoned a few years ago. It's used by cuahsi.wof services, and maybe others I'm not aware of.

suds-community is a fork of suds-jurko that is being actively maintained and advanced. Replace suds-jurko with suds-community. There will probably be some breaking changes. But it'll make it easier to address problems with SOAP WSDL caching and file permissions that I've run into (ref: ulmo/cuahsi/wof/core.py#L278)

I've requested the creation of a suds-community conda package on conda-forge.

emiliom commented 4 years ago

The conda package is now available: https://anaconda.org/conda-forge/suds-community

conda install -c conda-forge suds-community

conda-forge feedstock: https://github.com/conda-forge/suds-community-feedstock

Initial conda-forge recipe was staged at https://github.com/ulmo-dev/staged-recipes. I should probably delete this repo now.

emiliom commented 3 years ago

Is there a new suds-community release since we first created the conda-forge package?

(update 2021-6-18) Yes. v0.8.5 was issued as a tagged release on 2021-5-14
(update 2021-6-20) A conda-forge bot had already submitted a PR to update the recipe & feedstock to 0.8.5. I reviewed it, implemented the recommended (required?) lint change (add a python lower bound: python>= 3.6), then merged the PR.

emiliom commented 3 years ago

It turns out that suds-jurko is not causing a dependency resolution failure on Python 3.8. All Python 3.x tests (3.6, 3.7, 3.8, 3.9) still pass. On the other hand, suds-community won't work because it hasn't implemented the suds caching strategy we use in the cuahsi wof reader. See https://github.com/suds-community/suds/issues/10. Leaving this issue open for now.