search

ulmo-dev / ulmo

clean, simple and fast access to public hydrology and climatology data.
http://ulmo.readthedocs.org
Other
169 stars 63 forks source link

Fix NWIS and WOF tests #219

Closed emiliom closed 1 year ago

emiliom commented 1 year ago

Fixed errors occurring with NWIS usgs_nwis_test.py::test_get_sites_with_extra_kwarg and WOF wof_test.py::test_core_get_values_waterml_1_1 tests. Both errors involved changes on the data service end, which required small changes to the tests.

Note: now ALL tests that have not been explicitly excluded (skipped) are passing.

After PR #218, where I updated the GitHub CI action, the CI tests spawned by this PR should all succeed :crossed_fingers:

emiliom commented 1 year ago

The 3.10 test failed, but all others succeeded. The 3.10 test failure is unrelated to the specifics of each test, and is instead a failure to find the conda environment that was created. I suspect that's a hiccup, not a persistent failure. But I'll monitor what happens on the next PR.

I'll submit another PR to remove Python 3.7 from the test matrix. Hopefully the lower number of Python versions testesd will make the 3.10 failure less likely.