ulnagar / Constellation

0 stars 0 forks source link

Absence notification handlers cannot find absences as they have not been persisted yet #26

Closed ulnagar closed 1 year ago

ulnagar commented 1 year ago

When running the AbsenceMonitorJob, when raising a command to SendAbsenceNotificationToParent, the handler cannot load the absence as it has not yet been persisted to the database.

Prefer option 1 as this ensures the data is complete in the persistence store, even if the notification fails to send. Perhaps look at moving the notifications to a domain event so they can be handled out-of-band. This will require that each absence is sent as a separate email which may be an issue.

ulnagar commented 1 year ago

Tested working ok and slated for inclusion in R1.11