search

ulnagar / Constellation

0 stars 0 forks source link

New School Contacts are not being added to Partner School Teams #90

Closed ulnagar closed 4 months ago

ulnagar commented 5 months ago

When a SchoolContactRole is created, it fires the SchoolContactRoleCreatedDomainEvent, including the AddToPartnerSchoolTeam handler. This handler should create MSTeamOperations for adding the user to either or both of the Secondary and Primary partner school teams.

It appears that the schools are retrieved without the list of students, meaning that they are not properly identified as either Primary or Secondary schools and the job completes gracefully.

Update code to detect primary or secondary school status properly. Maybe this should be done at the repository layer.

ulnagar commented 4 months ago

Tested without issue. Scheduled to be released to production with R1.14.4