uloco / theme-bluloco-light

A fancy and sophisticated light designer color scheme.
https://marketplace.visualstudio.com/items?itemName=uloco.theme-bluloco-light
GNU Lesser General Public License v3.0
95 stars 11 forks source link

Python's IN function not formatted correctly? #58

Closed br4n5 closed 2 years ago

br4n5 commented 2 years ago

There is a inconsistency on how ‘IN’ is formatted in the Python’s IF and FOR functions. While the ‘IN’ in IF is, say, correctly formatted the same does not happen in the ‘IN’ in IF function. The cobalt I use apparently works correctly: You can check a comparison of the screenshots I have done: https://imgur.com/ra1vicl https://imgur.com/zHFm2tl https://imgur.com/GkNk6At

uloco commented 2 years ago

Hi, thanks for reporting / requesting.

This is because the in is recognized as a control flow keyword (like for, if etc.) and as an operator in the second case. So are the other keyword operators and is or and not that have the same color (purpleish)

From my perspective this is by design, since operators (like &&, || etc.) are always this color. Otherwise it is also a keyword and would make sense to make it blue.

When I change this, it will also change how and or, etc. is rendered. Is this what you want?

br4n5 commented 2 years ago

Hi Mr, thank you for sparing some time to write back.

I was asking out of curiosity since I have just started studying python and spotted this “issue”.

So I am not sure how it effectively affects people’s coding.

Your theme rocks, by the way.

Wish you and your family nothing but the best of luck!


From: Umut Topuzoğlu @.> Sent: Thursday, January 27, 2022 5:33:46 PM To: uloco/theme-bluloco-light @.> Cc: BrunOrc @.>; Author @.> Subject: Re: [uloco/theme-bluloco-light] Python's IN function not formatted correctly? (Issue #58)

Hi, thanks for reporting / requesting.

This is because the in is recognized as a control flow keyword (like for, if etc.) and as an operator in the second case. So are the other keyword operators and is or and not that have the same color (purpleish)

From my perspective this is by design, since operators (like &&, || etc.) are always this color. Otherwise it is also a keyword and would make sense to make it blue.

When I change this, it will also change how and or, etc. is rendered. Is this what you want?

— Reply to this email directly, view it on GitHubhttps://github.com/uloco/theme-bluloco-light/issues/58#issuecomment-1023015002, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGMTB3JHQW6LTNT4JTI5MJ3UYEGPVANCNFSM5M447BLA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.Message ID: @.***>

uloco commented 2 years ago

Thanks, glad you like it :)

Well you are right, it does make sense to change something here, but I guess I should update the places where I changed the keyword operators to blue. So it is the other way round.

Operators in this purpleish color are normally special characters (like &, |, etc.), but all word based operators should also look purple since this is more consistent.

I wish you also good luck and success with your studies.

uloco commented 2 years ago

I guess I like how it is at the moment. sorry will not change. if it bugs you, you can override in your settings like so

  "editor.tokenColorCustomizations": {
    "[Bluloco Light],[Bluloco Light Italic]": {
      "textMateRules": [
        {
          "scope": "keyword.operator.logical.python",
          "settings": {
            "foreground": "#0098DD"
          }
        }
      ]
    }
  },