ulrikstrid commented 2 years ago

Fixes #44

Sorry for the delay, does this look like what you would expect @Lupus?

anmonteiro commented 2 years ago

I'd be in favor of having a Well_known module with common claims that we'd expect users to get

ulrikstrid commented 2 years ago

I think we've had this discussion "offline" är some point. We then said that these should be in other repos. But I wouldn't mind having Wellknown.oidc : jwt -> oidc_claims or something.

anmonteiro commented 2 years ago

I mean having:

module Well_known = struct
  let sub = "sub"
  ....
end

codecov[bot] commented 2 years ago

Codecov Report

Merging #46 (8bd11fc) into master (7427b97) will increase coverage by 0.12%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   76.76%   76.89%   +0.12%     
==========================================
  Files           8        8              
  Lines         749      753       +4     
==========================================
+ Hits          575      579       +4     
  Misses        174      174

Impacted Files	Coverage Δ
jose/Jwt.ml	`81.08% <100.00%> (+2.29%)`	:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Lupus commented 2 years ago

Looks good to me! 👍

ulrikstrid / ocaml-jose

Add simpler way of getting claims #46

Codecov Report