search

ulrikstrid / ocaml-jose

https://ulrikstrid.github.io/ocaml-jose/
MIT License
53 stars 4 forks source link

Correct thumbprints #47

Closed ulrikstrid closed 2 years ago

ulrikstrid commented 2 years ago

Fixes #45

The only thing is that the base64 encoding of the golang implementation seems to be wrong(?) since they have a + instead of -. But I guess we might want to just return a Cstruct.t here as per #43, but that can be a follow up PR since this fixes the immediate bug.

codecov[bot] commented 2 years ago

Codecov Report

Merging #47 (dd510c5) into master (541e1a3) will increase coverage by 0.68%. The diff coverage is 58.62%.

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   76.08%   76.76%   +0.68%     
==========================================
  Files           8        8              
  Lines         740      749       +9     
==========================================
+ Hits          563      575      +12     
+ Misses        177      174       -3
Impacted Files Coverage Δ
jose/Jwk.ml 72.39% <58.62%> (+1.19%) :arrow_up:
jose/Jwa.ml 78.12% <0.00%> (+3.12%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Lupus commented 2 years ago

The only thing is that the base64 encoding of the golang implementation seems to be wrong(?)

Probably the difference is from url-safe base64 vs ordinary base64, see RFC 4648

ulrikstrid commented 2 years ago

Yes, that makes sense @Lupus :sweat_smile: