Commit revision 10 bug

[GoogleCodeExporter]

What steps will reproduce the problem?
1. download the php 5.2.17 source from php.net
2. patch them with latest patch
3. try to compile with soap extension enabled

What is the expected output? What do you see instead?
The error about macros
Z_SET_ISREF_PP
Z_ADDREF_PP
will be thrown, compilation aborted

Please provide any additional information below.
Those macros were added in php 5.3 (and also existed in php 5.2.6 or such, but 
were deleted later).
To fix you need attached diff, please import to the trunk :)

Original issue reported on code.google.com by romans.h...@gmail.com on 22 Feb 2012 at 1:44

Attachments:

• fixtrunk.diff

[GoogleCodeExporter]

I can't reproduce this problem, all compiled correctly

Original comment by svyatosl...@gmail.com on 25 May 2012 at 4:28

• Changed state: WontFix

[GoogleCodeExporter]

You can see that it can't be compiled even with grep command by grepping those 
macros with patched source (with trunk patch, not security!). Those macros only 
appear in the one place by using them, no declaration/etc. But the issue is not 
actual anymore for me, because i have moved to the security branch, because of 
craching issues and no-needed by me pathes. Thanks!

Original comment by romans.h...@gmail.com on 28 May 2012 at 9:33

[GoogleCodeExporter]

Today it was fixed.

Original comment by svyatosl...@gmail.com on 27 Jun 2012 at 3:46

• Changed state: Fixed