search

ulsdevteam / alma-payment-microservice

Microservice for fines & fees payment in Alma thru Authorize.net
MIT License
0 stars 0 forks source link

Should the invoice number be formatted based on the admin's choice? #4

Open ctgraham opened 3 years ago

ctgraham commented 3 years ago

https://github.com/ulsdevteam/alma-payment-microservice/blob/ff69d9e4707bdf9ef12ab8a65fa7388f78c19df7/index.php#L37-L40

Minimally, add a delimiter between the primary id and the timestamp.

ctgraham commented 3 years ago

Also, the "A" (or user chosen prefix) should probably be reproduced here: https://github.com/ulsdevteam/alma-payment-microservice/blob/ff69d9e4707bdf9ef12ab8a65fa7388f78c19df7/index.php#L62

In the future, the same Authorize.net account may be reused for other systems, where no Pitt ID (or Alma ID) is available.

Perhaps there is another property we can set to indicate originating system?

ctgraham commented 3 years ago

The Alma primary identifier itself may exceed Authorize.net's allowed 20 characters for the invoice number.