search

ulsdevteam / islandora_datastreams_io

Islandora Datastreams Import / Export Utility
GNU General Public License v2.0
5 stars 4 forks source link

Fix nonMODS imports #10

Closed bryjbrown closed 6 years ago

bryjbrown commented 6 years ago

This PR adds an else statement so that datastreams that aren't MODS records can be imported as well.

Prior to this PR, any file with datastreams to be imported that werent MODS would unzip just fine, but the module would claim to find no datastreams to import. I think this might be a bug introduced when features were added for MODS validation. I simply copied the code that fires on a successful MODS validation check, and added it to a an else statement so that it does the exact same thing for nonMODS datastreams.

This PR builds off of the code in https://github.com/ulsdevteam/islandora_datastreams_io/pull/9.

wgilling commented 6 years ago

Trying to unwrap the foreach / if / if / else . if / else . else in that code... at least something is not indented correctly. I will revisit this after lunch to see if the merged code works in my VM.

wgilling commented 6 years ago

Looks good.