ulsdevteam / islandora_datastreams_io

Islandora Datastreams Import / Export Utility
GNU General Public License v2.0
5 stars 4 forks source link

Update label routine throws errors #11

Open petermacdonald opened 6 years ago

petermacdonald commented 6 years ago

Am testing out this module for the first time. Wonderful idea! Thanks so much.

Using: admin/islandora/datastreams_io/update_label Islandora: 7x-1.11

Test 1. I specified a "collection" and clicked "Update" but immediately got this report back.

At least one of the PID values were not able to be loaded as an object. These are: 'hamLibCom:56838 hamLibCom:56931 hamLibCom:56901 hamLibCom:56835 hamLibCom:56853 hamLibCom:56784 hamLibCom:56796 hamLibCom:56775 hamLibCom:56886 hamLibCom:57015 hamLibCom:56937 hamLibCom:56766 hamLibCom:56730 hamLibCom:56709 hamLibCom:57057 hamLibCom:57027 hamLibCom:56976 hamLibCom:56733 hamLibCom:56883 hamLibCom:56979 hamLibCom:56898 hamLibCom:57054 hamLibCom:56802 hamLibCom:56958 hamLibCom:56811 hamLibCom:56862 hamLibCom:56982 hamLibCom:56952 hamLibCom:57039 hamLibCom:56967 hamLibCom:56973 hamLibCom:56718 hamLibCom:56757 hamLibCom:56856 hamLibCom:56826 hamLibCom:56994 hamLibCom:57078 hamLibCom:56727 hamLibCom:57069 hamLibCom:57006 hamLibCom:56799 hamLibCom:57012 hamLibCom:56877 hamLibCom:56964 hamLibCom:56991 hamLibCom:56961 hamLibCom:56751 hamLibCom:56922 hamLibCom:56808 hamLibCom:56928 hamLibCom:57018 hamLibCom:56889 hamLibCom:56859 hamLibCom:57045 hamLibCom:56874 hamLibCom:56880 hamLibCom:56829 hamLibCom:57009 hamLibCom:56769 hamLibCom:56739 hamLibCom:56940 hamLibCom:57024 hamLibCom:56823 hamLibCom:57036 hamLibCom:56724 hamLibCom:56817 hamLibCom:56793 hamLibCom:57048 hamLibCom:56955 hamLibCom:57066 hamLibCom:56844 hamLibCom:56919 hamLibCom:57003 hamLibCom:56943 hamLibCom:56742 hamLibCom:56925 hamLibCom:56721 hamLibCom:56820 hamLibCom:56997 hamLibCom:56850 hamLibCom:56871 hamLibCom:57075 hamLibCom:57042 hamLibCom:56985 hamLibCom:56910 hamLibCom:56715 hamLibCom:56892 hamLibCom:56787 hamLibCom:56745 hamLibCom:56748 hamLibCom:57051 hamLibCom:56706 hamLibCom:56790 hamLibCom:56781 hamLibCom:56841 hamLibCom:57021 hamLibCom:56868 hamLibCom:56832 hamLibCom:56736 hamLibCom:56988 hamLibCom:56904 hamLibCom:57063 hamLibCom:57072 hamLibCom:56916 hamLibCom:57030 hamLibCom:56913 hamLibCom:56949 hamLibCom:56934 hamLibCom:56847 hamLibCom:56907 hamLibCom:56895 hamLibCom:56712 hamLibCom:56970 hamLibCom:56763 hamLibCom:57000 hamLibCom:56778 hamLibCom:56772 hamLibCom:57060 hamLibCom:56805 hamLibCom:56814 hamLibCom:56754 hamLibCom:56865 hamLibCom:57033 hamLibCom:56760 hamLibCom:36843 hamLibCom:36847 hamLibCom:36848 hamLibCom:36849 hamLibCom:36844 hamLibCom:36845 hamLibCom:36846 hamLibCom:36855 hamLibCom:36856 hamLibCom:36857 hamLibCom:36862 hamLibCom:36863 hamLibCom:36864 hamLibCom:36858 hamLibCom:36859 hamLibCom:36860 hamLibCom:36861 hamLibCom:36854 hamLibCom:36851 hamLibCom:36852 hamLibCom:36853 hamLibCom:36850 hamLibCom:56946'

It appears that none of the objects in this collection were updated.

Test 2. Then I tried the update_label again but this time I specified "Pid Values" as follows:

hamLibCom:56838 hamLibCom:56931

but immediately got this report back this:

Warning: SimpleXMLElement::construct(): Entity: line 1: parser error : Start tag expected, '<' not found in islandora_datastreams_io_doLabel() (line 204 of /home2/lisham/public_html/sites/all/modules/contrib/islandora_datastreams_io/includes/update_label.form.inc). Warning: SimpleXMLElement::__construct(): 1 in islandora_datastreams_io_doLabel() (line 204 of /home2/lisham/public_html/sites/all/modules/contrib/islandora_datastreams_io/includes/update_label.form.inc). Warning: SimpleXMLElement::construct(): ^ in islandora_datastreams_io_doLabel() (line 204 of /home2/lisham/public_html/sites/all/modules/contrib/islandora_datastreams_io/includes/update_label.form.inc). Exception: String could not be parsed as XML in SimpleXMLElement->__construct() (line 204 of /home2/lisham/public_html/sites/all/modules/contrib/islandora_datastreams_io/includes/update_label.form.inc)

Thanks, Peter MacDonald

wgilling commented 6 years ago

Peter,

Oh, boy ... this is embarrassing. The "update label" and "delete datastreams" methods are still just in development -- and these changes should be on a feature branch until they have been fully-developed.

Is there a present need to update a batch of objects' object label values?

If I have some time soon, I will isolate these changes into a feature branch so that it does not mislead anybody else even though the readme mentions that the "update label" idea is in development.

thanks, Brian Gillingham

petermacdonald commented 6 years ago

My bad, actually I should have read the documentation for this module more carefully. I can see from the documentation that this feature is not yet available. No problem, Brian, and don't feel any special pressure to work on it for me. Our labels are fine as they are, just not perfect.

Cheers, Peter