search

ulsdevteam / lcsu

0 stars 0 forks source link

Why is the CakePHP contain[] relationship unused? #11

Closed ctgraham closed 5 years ago

ctgraham commented 5 years ago

You are pulling related Trays and Module for a Shelf, but you haven't used the contain[] relationship to do this. Is this intentional?

https://github.com/ulsdevteam/lcsu/blob/fd1e3dc5a1307831f0275fafc29c4aa746a60f90/src/Controller/ShelvesController.php#L38-L46

Similarly here with a Tray's Status: https://github.com/ulsdevteam/lcsu/blob/fd1e3dc5a1307831f0275fafc29c4aa746a60f90/src/Controller/TraysController.php#L50-L55

ctgraham commented 5 years ago

I need to review this further.