search

ulsdevteam / lcsu

0 stars 0 forks source link

Is the allocate id a shelf or a tray size or other? #12

Closed ctgraham closed 5 years ago

ctgraham commented 5 years ago

What is target id of ShelvesController::allocate()?

https://github.com/ulsdevteam/lcsu/blob/fd1e3dc5a1307831f0275fafc29c4aa746a60f90/src/Controller/ShelvesController.php#L214-L247

PHPDoc says it is a tray id: https://github.com/ulsdevteam/lcsu/blob/fd1e3dc5a1307831f0275fafc29c4aa746a60f90/src/Controller/ShelvesController.php#L218

But the tray id seems to be coming from the querystring: https://github.com/ulsdevteam/lcsu/blob/fd1e3dc5a1307831f0275fafc29c4aa746a60f90/src/Controller/ShelvesController.php#L228

And $id is unchecked/unused until the redirect: https://github.com/ulsdevteam/lcsu/blob/fd1e3dc5a1307831f0275fafc29c4aa746a60f90/src/Controller/ShelvesController.php#L246

ctgraham commented 5 years ago

Resolved per https://github.com/ulsdevteam/lcsu/commit/0be6eeaa0237496a2d7169c29d8f42c501f9215f#diff-256e16d0d4c91ba67f5da8aacec3bd74R209