search

ulsdevteam / lcsu

0 stars 0 forks source link

Move configuration items to app.php #13

Closed ctgraham closed 5 years ago

ctgraham commented 5 years ago

Any configuration should be part of the config/app.php.

For example: https://github.com/ulsdevteam/lcsu/blob/fd1e3dc5a1307831f0275fafc29c4aa746a60f90/src/Utility/PhpNetworkLprPrinter.php#L21

https://github.com/ulsdevteam/lcsu/blob/fd1e3dc5a1307831f0275fafc29c4aa746a60f90/src/Utility/PhpNetworkLprPrinter.php#L84

Also: https://github.com/ulsdevteam/lcsu/blob/fd1e3dc5a1307831f0275fafc29c4aa746a60f90/src/Auth/EnvAuthenticate.php#L97 or, remove the option documentation: https://github.com/ulsdevteam/lcsu/blob/fd1e3dc5a1307831f0275fafc29c4aa746a60f90/src/Auth/EnvAuthenticate.php#L45-L58

For any expected configuration in app.php (since it is not captured in version control), add sample configuration in config/app.default.php

edensung25 commented 5 years ago

Should I use PHP define or [cakePHP configuration]? (https://book.cakephp.org/3.0/en/development/configuration.html#bootstrapping-cakephp) Can I put move those parameters into config/Bootstrap.php?

ctgraham commented 5 years ago

These should be done in the cake configuration (config/app.php or an additional included file).

https://book.cakephp.org/3.0/en/development/configuration.html

ctgraham commented 5 years ago

Configuration parameters which are not secure should be set so that the application will work out-of-the-box:

https://github.com/ulsdevteam/lcsu/blob/1a2e45a2edd724af3ff84dd31a73ab8312f33296/config/app.default.php#L387-L399

For example, the constants for Managers and Scanners should be 1 and 2.

edensung25 commented 5 years ago

updated in commit 1df1cdad92bd5e2f8d65ebc78cf69398c2bf644c and 9ff36da3560810ed92e0f16b618f653f60ec710c

ctgraham commented 5 years ago

Resolved.