ulsdevteam / lcsu

0 stars 0 forks source link

Orphaned functions? #2

Closed ctgraham closed 5 years ago

ctgraham commented 5 years ago

Are add(), edit(), and delete() functions actually used within the application?

https://github.com/ulsdevteam/lcsu/blob/fd1e3dc5a1307831f0275fafc29c4aa746a60f90/src/Controller/BooksController.php#L46-L112

I think these are default baked functions that can and should be removed.

ctgraham commented 5 years ago

Resolved per https://github.com/ulsdevteam/lcsu/commit/0be6eeaa0237496a2d7169c29d8f42c501f9215f#diff-283be7107b7797b5b081f09ffea88aaeL46