Closed ctgraham closed 5 years ago
The scan() method and the scanList() method are nearly identical.
scan()
scanList()
https://github.com/ulsdevteam/lcsu/blob/fd1e3dc5a1307831f0275fafc29c4aa746a60f90/src/Controller/BooksController.php#L114-L186
Document any intended functional difference in the PHPDoc.
If 90% of the code is intended to be identical, create a helper method or methods to consolidate the repeated code.
Resolved per https://github.com/ulsdevteam/lcsu/commit/0be6eeaa0237496a2d7169c29d8f42c501f9215f#diff-283be7107b7797b5b081f09ffea88aaeL123
ctgraham
commented
5 years ago ctgraham
commented
5 years ago
The
scan()method and thescanList()method are nearly identical.https://github.com/ulsdevteam/lcsu/blob/fd1e3dc5a1307831f0275fafc29c4aa746a60f90/src/Controller/BooksController.php#L114-L186
Document any intended functional difference in the PHPDoc.
If 90% of the code is intended to be identical, create a helper method or methods to consolidate the repeated code.