ctgraham
commented
5 years ago Resolved per:
- https://github.com/ulsdevteam/lcsu/commit/0be6eeaa0237496a2d7169c29d8f42c501f9215f#diff-431d70411e881c0309ee2ef94898c74fR54
- https://github.com/ulsdevteam/lcsu/commit/0be6eeaa0237496a2d7169c29d8f42c501f9215f#diff-431d70411e881c0309ee2ef94898c74fR104
- https://github.com/ulsdevteam/lcsu/commit/0be6eeaa0237496a2d7169c29d8f42c501f9215f#diff-431d70411e881c0309ee2ef94898c74fR144
- etc.
PHPDoc @param names should match function parameter names
See discrepancies, for example:
https://github.com/ulsdevteam/lcsu/blob/fd1e3dc5a1307831f0275fafc29c4aa746a60f90/src/Command/FileLoaderCommand.php#L51-L55
https://github.com/ulsdevteam/lcsu/blob/fd1e3dc5a1307831f0275fafc29c4aa746a60f90/src/Command/FileLoaderCommand.php#L99-L103
PHPDoc is missing
See, for example: https://github.com/ulsdevteam/lcsu/blob/fd1e3dc5a1307831f0275fafc29c4aa746a60f90/src/Command/FileLoaderCommand.php#L140-L263