search

ulsdevteam / lcsu

0 stars 0 forks source link

Translate only the relevant output #8

Closed ctgraham closed 5 years ago

ctgraham commented 5 years ago

https://github.com/ulsdevteam/lcsu/blob/fd1e3dc5a1307831f0275fafc29c4aa746a60f90/src/Controller/ModulesController.php#L140

should be: $this->Flash->success(__("Label: ").$shelf->shelf_barcode); because the shelf barcode is not subject to translation.

Also: https://github.com/ulsdevteam/lcsu/blob/fd1e3dc5a1307831f0275fafc29c4aa746a60f90/src/Controller/ShelvesController.php#L157

https://github.com/ulsdevteam/lcsu/blob/fd1e3dc5a1307831f0275fafc29c4aa746a60f90/src/Controller/ShelvesController.php#L183

ctgraham commented 5 years ago

Why remove the successful print messages? E.g. https://github.com/ulsdevteam/lcsu/commit/0be6eeaa0237496a2d7169c29d8f42c501f9215f#diff-256e16d0d4c91ba67f5da8aacec3bd74L183

edensung25 commented 5 years ago

More changes are in 8e7644c31b90066dbf627d98f663b6374ae00bf0. About the successful print messages, I thought those messages will take to much spaces on the page. So I remove them. In the the commit 8e7644c31b90066dbf627d98f663b6374ae00bf0 , I use $this->Flash->success(__('All labels are printed out successfully.')); instead.

ctgraham commented 5 years ago

Resolved.