ulsdevteam / pkp-clamav

Clam AV plugin for PKP OJS / OMP
GNU General Public License v2.0
5 stars 5 forks source link

Version check URL is malformed #16

Closed ctgraham closed 2 years ago

ctgraham commented 2 years ago

We attempt to formulate a PageRouter URL here: https://github.com/ulsdevteam/pkp-clamav/blob/38838fd63ad4713b51d07c8ec008d12df7120e58/ClamavSettingsForm.inc.php#L67 But $request is still a ComponentRouter instance, so this constructs something of the form of: https://domain.tld/ojs/index.php/clamav/clamavVersion/get? rather than https://domain.tld/ojs/index.php/context/clamav/clamavVersion/get?

For an alternate approach, see: https://github.com/ulsdevteam/pkp-emailIssueToc/blob/master/emailIssueTocPlugin.inc.php#L61-L70 but there really ought to be something less kludgy.