search

ulsdevteam / sms-send-receive

0 stars 0 forks source link

Cleanup error handling #1

Open ctgraham opened 3 years ago

ctgraham commented 3 years ago

Capture the HTTP response in the Exception: https://github.com/ulsdevteam/sms-send-receive/blob/3a7fc2d31654a698966d1af8d20c94c9ab3bc690/send.php#L36-L37

Then write the original $line to the failure log for retry: https://github.com/ulsdevteam/sms-send-receive/blob/3a7fc2d31654a698966d1af8d20c94c9ab3bc690/send.php#L51-L53 and print the Exception message to STDERR for us to see in cronic messages.

Error counting should then be unneeded. https://github.com/ulsdevteam/sms-send-receive/blob/3a7fc2d31654a698966d1af8d20c94c9ab3bc690/send.php#L56-L59

wopsononock commented 3 years ago

Addressed in bf4b634d9d9eec79aeb4e1919dd8a698cef3a210