search

ultimate-comparisons / ultimate-comparison-framework

The base of all ultimate-comparisons. Follow the README and create your own ultimate comparison.
http://ultimate-comparisons.github.io/ultimate-comparison-framework/
MIT License
16 stars 7 forks source link

Criteria-type "url" does not work #151

Closed schneisn closed 6 years ago

schneisn commented 6 years ago

Defining a criterion-type as "url" and showing it in the table breaks the table 😆 The example has a "Download" section with the type "url". Markdown-file:

## Download
- https://github.com/randombit/botan/archive/2.0.0.zip

Comparison.yml:

  - Download:
      detail: true
      search: false
      table: false
      type: url

E.g. the table without a "url" type: image With "url" type: image

If the url is only shown in the detail view, the detail view does not work correctly anymore Without "url" type: image With "url" type: Only the "Description"-section is shown image

koppor commented 6 years ago

This field is currently used for the header. Format:

Name - URL

In the examples, it is used as the id field. We change the type to uct (for ultimate comparision title or "ollyspezial")

To fix your issue, change the type to markdown. Please enclose the URL in <>. Officially, GitHub flavored markdown does not support autlinking: https://github.github.com/gfm/#example-595

koppor commented 6 years ago

Please report back if it works.

schneisn commented 6 years ago

Works with type: markdown and enclosing the url in <> 👍