search

ultimate-research / ssbh_lib

Reading and writing SSBH file formats in Rust
MIT License
8 stars 3 forks source link

Update MeshEx bounding sphere representation #142

Closed ThatNintendoNerd closed 1 year ago

ThatNintendoNerd commented 1 year ago

The MeshEx implementation was updated in both ssbh_lib and ssbh_data to retype the bounding_sphere field from Vector4 to ssbh_lib::formats::mesh::BoundingSphere. Some comments were updated in the related modules and some new comments were added to the EntryFlags struct to partially document the unknown flags.

Additionally, due to changes over time in the JSON representation of the supported file formats, the two JSON excerpts in the README were updated to reflect the current output.

ScanMountGoat commented 1 year ago

The changes look good. In the future, please limit pull requests to one change to make things easier to review. Additional changes that may seem obvious to include to you like a typo or undocumented field may not be to the person reviewing. Git also doesn't make it easy to accept part of a pull request. Smaller changes are usually easier to get accepted for this reason.

ScanMountGoat commented 1 year ago

Once the compile errors and visibility issue are fixed, this should be good to merge.

ThatNintendoNerd commented 1 year ago

The changes look good. In the future, please limit pull requests to one change to make things easier to review. Additional changes that may seem obvious to include to you like a typo or undocumented field may not be to the person reviewing. Git also doesn't make it easy to accept part of a pull request. Smaller changes are usually easier to get accepted for this reason.

I understand and will keep that in mind next time. Apologies for the inconvenience.