jgarciamesa commented 7 years ago

…ror messages

dng-jenkins commented 7 years ago

Can one of the admins verify this patch?

reedacartwright commented 7 years ago

Jenkins, okay to test.

codecov[bot] commented 7 years ago

Codecov Report

Merging #224 into develop will decrease coverage by 0.47%. The diff coverage is 10%.

@@             Coverage Diff             @@
##           develop     #224      +/-   ##
===========================================
- Coverage    67.99%   67.52%   -0.48%     
===========================================
  Files           68       68              
  Lines         6384     6445      +61     
  Branches      1123     1126       +3     
===========================================
+ Hits          4341     4352      +11     
- Misses        1576     1635      +59     
+ Partials       467      458       -9

Impacted Files	Coverage Δ
src/include/dng/task/dnm.h	`100% <ø> (ø)`	:arrow_up:
src/dnm/bcf2Qcall.cc	`85.34% <0%> (+0.72%)`	:arrow_up:
src/dng-dnm.cc	`77.11% <11.11%> (-2.02%)`	:arrow_down:
src/lib/genotyper.cc	`55.7% <0%> (-25.31%)`	:arrow_down:
src/include/dng/mutation.h	`94.44% <0%> (-1.86%)`	:arrow_down:
src/include/dng/task/call.xmh	`100% <0%> (ø)`	:arrow_up:
src/include/dng/depths.h	`94.07% <0%> (ø)`	:arrow_up:
src/include/dng/task/loglike.xmh	`100% <0%> (ø)`	:arrow_up:
src/lib/task/loglike.cc	`0% <0%> (ø)`	:arrow_up:
src/include/dng/probability.h	`100% <0%> (ø)`	:arrow_up:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 83115a1...e6c690b. Read the comment docs.

reedacartwright commented 7 years ago

Can you add the DNG_ prefix before your definitions?

ultimatesource / denovogear

Fix issue #151, dng-dnm assumes DP is zero and improve BCF parsing er… #224

Codecov Report