search

ultimatesource / denovogear

A program to detect denovo-variants using next-generation sequencing data.
http://www.nature.com/nmeth/journal/v10/n10/full/nmeth.2611.html
GNU General Public License v3.0
49 stars 25 forks source link

Fixed issue 209, dng-loglike segfaults on bam #231

Closed jgarciamesa closed 7 years ago

jgarciamesa commented 7 years ago

The segmentation fault message was thrown because dng-loglike requires a fasta file as input, along with a ped and a sam/bam file. Check has been added to assure a fasta file is given.

dng-jenkins commented 7 years ago

Can one of the admins verify this patch?

reedacartwright commented 7 years ago

Jenkins, Okay to test

codecov[bot] commented 7 years ago

Codecov Report

Merging #231 into develop will decrease coverage by 0.06%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #231      +/-   ##
===========================================
- Coverage     67.8%   67.73%   -0.07%     
===========================================
  Files           70       70              
  Lines         6519     6525       +6     
  Branches      1140     1143       +3     
===========================================
  Hits          4420     4420              
- Misses        1632     1636       +4     
- Partials       467      469       +2
Impacted Files Coverage Δ
src/lib/task/call.cc 81.48% <0%> (-0.33%) :arrow_down:
src/lib/task/loglike.cc 0% <0%> (ø) :arrow_up:
src/lib/task/pileup.cc 60.9% <0%> (-0.93%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 81c7d2b...58fb722. Read the comment docs.